Stepping stone for .NET Core migrations#1871
Open
kant2002 wants to merge 2 commits intosmartstore:4.xfrom
Open
Stepping stone for .NET Core migrations#1871kant2002 wants to merge 2 commits intosmartstore:4.xfrom
kant2002 wants to merge 2 commits intosmartstore:4.xfrom
Conversation
This is basis for migrate project to new MSBuild format which in itself, required to try run code in ASP.NET Core workloads
- Services project cannot be converted due to reliance on Web Service (can be moved to separate project) -Projects inside `Tests` and `Tools` folders was not converted to due to significan changes which can prevent them from reviewing PR - Unused files from `Migrations` was removed. These files was not part of the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is example of work what can be done to start moving into direction of .NET Core. That big work, but somethings which allow. I attempt to split onto commits, to indicate milestones.
packages.configtoPackageReferenceThis is basis for migrate project to new MSBuild format which in itself, required to try run code in ASP.NET Core workloads
This should be improved even more by migration of WebApplications, but it require individually vetting that some Nuget packages does not contains
contentor other unsupported features.Update Core,Data and Web.Framework to new MSBuild SDK style
-Projects inside
TestsandToolsfolders was not converted to due to significan changes which can prevent them from reviewing PRMigrationswas removed. These files was not part of the project.I cannot run test for Data project due to #1870.
Related to #1235